chore(deps): update anyhow by webern · Pull Request #1945 · DataDog/saluki

webern · 2026-06-29T14:28:07Z

Summary

Update a crate currently blocking check deny.

Change Type

Non-functional (chore, refactoring, docs)

How did you test this PR?

CI

References

N/A

tobz · 2026-06-29T14:32:53Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-06-29T14:32:57Z

View all feedbacks in Devflow UI.

2026-06-29 14:32:57 UTC ℹ️ Start processing command /merge

2026-06-29 14:33:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-06-29 14:40:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 36m (p90).

2026-06-29 15:08:21 UTC ℹ️ MergeQueue: This merge request was merged

pr-commenter · 2026-06-29T14:35:46Z

Binary Size Analysis (Agent Data Plane)

Baseline: e9dc0d3 · Comparison: 8006f56 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.64 MiB (baseline) vs 40.48 MiB (comparison)
Size Change: -164.52 KiB (-0.40%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
`tokio`	-63.72 KiB	4889
`core`	-22.08 KiB	15990
`anon.a873801c7d344698c7e141ea568eb541.8.llvm.772909932056020429`	-16.69 KiB	1
`anon.9bfc919f62f70222a56766133617f63b.644.llvm.3109927217915769846`	+16.69 KiB	1
`datadog_protos::trace_piecemeal_include::datadog`	-15.48 KiB	21
`anon.b3e0eab197798cc0da9737cc7a4b2b55.357.llvm.10946300965617976101`	-15.15 KiB	1
`anon.ef18d92d8e4b32a864b48426f5fbbe46.18.llvm.17302815010251625685`	+15.15 KiB	1
`piecemeal`	+14.51 KiB	43
`anon.6b6ec8798021cdb8f478ee5f74cd462d.10.llvm.12763542860581416599`	-13.72 KiB	1
`anon.a9030c24ed0837a8b572f3c7e56188a8.26.llvm.9410433398480454732`	+13.72 KiB	1
`figment`	-11.12 KiB	625
`[sections]`	-10.70 KiB	7
`tonic`	+9.24 KiB	481
`h2`	-7.97 KiB	783
`anon.4c31535843da9b7b5c410466b0ae9c40.167.llvm.1741467634674709001`	+7.77 KiB	1
`anon.a7a5ac420a821b949ace2821d7829b69.112.llvm.4013872591714255300`	-7.77 KiB	1
`ottl::parser::arena`	-6.90 KiB	18
`tracing_subscriber`	-6.42 KiB	158
`serde_json`	+5.99 KiB	361
`http_body_util`	-5.95 KiB	251

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +54.3Ki  [NEW] +54.2Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::he076a6e15a6ad1d3
  [NEW] +39.7Ki  [NEW] +39.5Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h0e9b4c3cbefd9205
  [NEW] +39.2Ki  [NEW] +39.1Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::he9b9b591783aa545
  [NEW] +33.7Ki  [NEW] +33.5Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::hbd47cee3ccd8c75b
  [NEW] +30.1Ki  [NEW] +30.0Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::hd1103149f636374a
  [NEW] +28.0Ki  [NEW] +27.8Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::h0001b2050e74c1b2
  [NEW] +25.3Ki  [NEW] +25.0Ki    _<saluki_components::sources::dogstatsd::_::<impl serde_core::de::Deserialize for saluki_components::sources::dogstatsd::DogStatsDConfiguration>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::hb48dacc0d24397de
  [NEW] +25.0Ki  [NEW] +24.8Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::ha2aef1b3fca7c8a3
  [NEW] +24.2Ki  [NEW] +24.0Ki    saluki_env::workload::collectors::containerd::NamespaceWatcher::build_initial_metadata_operations::_{{closure}}::h7db9c8b8000f4a98
  [NEW] +24.2Ki  [NEW] +24.0Ki    _<saluki_components::sources::dogstatsd::DogStatsDConfiguration as saluki_core::components::sources::builder::SourceBuilder>::build::_{{closure}}::hdc84339d3f9e8bea
  [DEL] -24.1Ki  [DEL] -23.9Ki    agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::_{{closure}}::ha578ddde22e2de13
  [DEL] -24.2Ki  [DEL] -24.0Ki    saluki_env::workload::collectors::containerd::NamespaceWatcher::build_initial_metadata_operations::_{{closure}}::h2f94705b93f853e1
  [DEL] -25.0Ki  [DEL] -24.9Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::h7afc200a0fa1e01e
  [DEL] -25.4Ki  [DEL] -25.1Ki    _<saluki_components::sources::dogstatsd::_::<impl serde_core::de::Deserialize for saluki_components::sources::dogstatsd::DogStatsDConfiguration>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::h20277497ec1c98a7
  [DEL] -28.3Ki  [DEL] -28.1Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::h562b182282594846
  [DEL] -30.2Ki  [DEL] -30.0Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::h02653f5b83fc945f
  [DEL] -33.7Ki  [DEL] -33.5Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::had2e01dc3fa09af5
  [DEL] -39.5Ki  [DEL] -39.3Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::ha18bd0afdd86cc2f
  [DEL] -39.7Ki  [DEL] -39.5Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::hc188f44480c77627
  [DEL] -54.5Ki  [DEL] -54.3Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::ha9e4e51eec0304f6
  -0.7%  -163Ki  -0.5% -99.3Ki    [56975 Others]
  -0.4%  -164Ki  -0.3%  -100Ki    TOTAL

pr-commenter · 2026-06-29T14:53:03Z

Regression Detector (Agent Data Plane)

Run ID: a01acfc7-3dba-42ab-8ad9-d798cfbec40a
Baseline: e9dc0d31 · Comparison: 8006f562 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_heavy	memory	⚪ +0.40	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.13	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ +0.02	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.06	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.27	metrics profiles logs

Bounds Checks: ❌ Failed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	9/10	❌ 141 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.5 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 65.1 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.2 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

## Summary Update a crate currently blocking check deny. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? CI ## References N/A Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com> bc51393

## Summary Update a crate currently blocking check deny. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? CI ## References N/A Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com>

## Summary Release-prep PR for **ADP 1.2.3** on `releases/1.2.x`. Bumps the version and bundles four fixes. Because 1.2.x is on Rust 1.96.0 (same as `main`), the `fetch_update` fix could be cherry-picked directly rather than needing the `#[allow(deprecated)]` workaround used on 1.1.0. 1. **Honor `site` when `dd_url` equals the default-derived URL** — corresponds to #2028 (`7ec65f2`). The Core Agent's config stream sends `dd_url` at its schema default (`https://app.datadoghq.com`) for every configuration, even when the operator only set `site`, so ADP routed all traffic to the US1 intake and `site` was effectively ignored (#1965). A `dd_url` equal to the default-derived URL is now filtered to `None` at deserialization, letting `site` determine the endpoint. `set_dd_url` bypasses serde and is unaffected. Adapted to the 1.2.x code (no `configured_primary_endpoint`), so the change is confined to the `dd_url` deserializer plus tests. 2. **Unblock the nightly `generate-api-docs` build** — cherry-pick of #2007 (`917e05f`). Newer nightly toolchains deprecate `Atomic*::fetch_update`; under `#![deny(warnings)]`, `cargo +nightly doc` turns that into a hard error. Since 1.2.x uses the 1.96.0 toolchain (where `try_update` is stable), the three call sites switch to `try_update`, matching `main`. (The `fixed_size.rs` hunk from the original commit was dropped — that method doesn't exist on 1.2.x and has no `fetch_update` to fix.) 3. **Update `anyhow`** — cherry-pick of #1945 (`bc51393`). Bumps `anyhow` 1.0.102 → 1.0.103 in `Cargo.lock` to unblock `check deny`. (The `2a7be76` hash is the gh-pages docs artifact for that PR; `bc51393` is the source commit.) 4. **Bump `crossbeam-epoch` to 0.9.20** — fresh fix for RUSTSEC-2026-0204. `crossbeam-epoch 0.9.18` (an invalid pointer dereference in the `fmt::Pointer` impl for `Atomic`/`Shared`) fails `check-deny`. This is a repo-wide issue; the equivalent fix for `main` is #2038. Applied directly here (semver-compatible, lockfile-only bump) rather than cherry-picked, since it landed on the release branches in parallel with the main PR. Plus a `chore(dev): Bump ADP to 1.2.3` commit updating `bin/agent-data-plane/Cargo.toml` and the lockfile. ## Test plan - New unit tests for the `dd_url`/`site` resolution (default filtered → `None`; explicit override wins; `set_dd_url` never filtered; end-to-end `build_primary_endpoint` for both cases). - `make check-deny` passes with the crossbeam-epoch bump. - `cargo check` passes for the affected crates on the pinned `1.96.0` toolchain, including the `try_update` call sites. Fixes #1965. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: webern <matt.briggs@datadoghq.com> Co-authored-by: jesse.szwedko <jesse.szwedko@datadoghq.com>

chore(deps): update anyhow

8006f56

webern requested a review from a team as a code owner June 29, 2026 14:28

tobz approved these changes Jun 29, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: waiting label Jun 29, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jun 29, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit bc51393 into main Jun 29, 2026
85 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Jun 29, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the m/update-anyhow branch June 29, 2026 15:08

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Jun 29, 2026

This was referenced Jul 6, 2026

chore(ci): Prepare 1.1.4 #2036

Merged

chore(ci): Prepare 1.2.3 #2037

Merged

Navigation Menu

Uh oh!

chore(deps): update anyhow - #1945

chore(deps): update anyhow#1945
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
m/update-anyhow

webern commented Jun 29, 2026

Uh oh!

tobz commented Jun 29, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Jun 29, 2026

Uh oh!

pr-commenter Bot commented Jun 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

webern commented Jun 29, 2026

Summary

Change Type

How did you test this PR?

References

Uh oh!

tobz commented Jun 29, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Jun 29, 2026

Binary Size Analysis (Agent Data Plane)

✅ Binary size difference within threshold

Uh oh!

pr-commenter Bot commented Jun 29, 2026

Regression Detector (Agent Data Plane)

Optimization Goals: ✅ No significant changes detected

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-worker-devflow-routing-ef8351 Bot commented Jun 29, 2026 •

edited

Loading