fix(otlp): emit otel.scope.name and otel.scope.version span meta

[jszwedko]

Summary

ADP was emitting only the deprecated otel.library.* span metadata, omitting otel.scope.name / otel.scope.version that the Datadog Agent started emitting in 7.82.0. Naively adding the keys unconditionally breaks regular MR CI (which validates against the pinned 7.81.0 baseline that doesn't emit them yet) while fixing nightly CI (which validates against the dev Agent that does).

Uses the Agent version gate from PR #2106 (datadog-agent-commons::agent_version::meets) to emit the keys only when the bundled Agent version is 7.82.0+, keeping both CI contexts green against their respective baselines.

Test plan

• Existing OTLP trace transform tests pass (8/8)
• New unit test test_otel_span_to_dd_span_scope_name_version_meta verifies both otel.library.* (always) and otel.scope.* (when version unknown → defaults to latest) are emitted
• Nightly correctness pipeline validates the gate end-to-end (5 otlp-traces tests currently failing)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75e8a51a1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: 6c17562 · Comparison: 200a5ff · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.57 MiB (baseline) vs 41.58 MiB (comparison)
Size Change: +15.98 KiB (+0.04%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
anon.52c3a273e91bfd564a24d5cb7ee806e3.1001.llvm.15135934386063498543	+17.25 KiB	1
anon.5f040b9cf0e85edcd98481965dce5e0f.55.llvm.9953283433741861364	-17.24 KiB	1
anon.85625ef020824a581138249b4bcd138f.2.llvm.15854790319231473015	+9.81 KiB	1
anon.e02c4dd8ff522f1fe4057746c120546c.61.llvm.14310455044692613470	-9.81 KiB	1
serde_core	+8.00 KiB	931
anon.0a98b3590f538e02e15153f12102fa90.2.llvm.17224994202189465113	+7.16 KiB	1
anon.776412e40142ec6aebcfae540905f9b2.970.llvm.3147434244572592408	-7.15 KiB	1
anon.061ad657bd5d2f931b857fc07cfe4e39.2.llvm.11063963451910516310	+4.38 KiB	1
anon.08d6aa4a5b49601fe6872e18f7d05cdc.547.llvm.5257818858558998185	-4.38 KiB	1
std	+3.89 KiB	281
datadog_agent_commons::ipc::client	+3.52 KiB	30
anon.dae1f8d3e2fd29cf80b1accc5cb6542e.215.llvm.11303867197650265754	+3.37 KiB	1
anon.7b1f3bc0f707c4b3c51155b8c4fa2d7c.215.llvm.5193126962255660412	-3.37 KiB	1
anon.b4f779bdb511619f62c8ac598cbf7a0c.424.llvm.13569147439722624680	-3.20 KiB	1
anon.8e2a8c1164ef4c1d7f6f0c904ac07035.258.llvm.2350770176468815035	+3.02 KiB	1
saluki_components::encoders::datadog	-2.79 KiB	444
anyhow	-2.72 KiB	1191
async_compression	-2.40 KiB	22
datadog_protos::agent_include::datadog	+2.40 KiB	80
anon.d62ce1e5b4442fd6d2640366c1f174a1.652.llvm.1446316904667073693	-2.33 KiB	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +56.3Ki  [NEW] +56.2Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h8b7f8c5d97ba6139
  [NEW] +44.0Ki  [NEW] +43.9Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h0fb925ad706e10ff
  [NEW] +38.5Ki  [NEW] +38.3Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h95f34135b15b6453
  [NEW] +30.6Ki  [NEW] +30.4Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::ha8992029ccc3e467
  [NEW] +30.6Ki  [NEW] +30.4Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h06b9e5ed272fda3d
  [NEW] +30.5Ki  [NEW] +30.3Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::h3fe1589e3c4d638d
  [NEW] +30.0Ki  [NEW] +29.9Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::h9a00c8b722d068b2
  [NEW] +28.1Ki  [NEW] +27.9Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::h29bc4bf05508540a
  [NEW] +27.5Ki  [NEW] +27.2Ki    _<saluki_components::sources::dogstatsd::_::<impl serde_core::de::Deserialize for saluki_components::sources::dogstatsd::DogStatsDConfiguration>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::h0f7ba74159d95446
  [NEW] +27.0Ki  [NEW] +26.8Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::hd69617ec6298c4df
  +0.1% +15.9Ki  +0.1% +6.42Ki    [33805 Others]
  [DEL] -27.1Ki  [DEL] -26.9Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::h32d551929f6fa3b6
  [DEL] -27.4Ki  [DEL] -27.1Ki    _<saluki_components::sources::dogstatsd::_::<impl serde_core::de::Deserialize for saluki_components::sources::dogstatsd::DogStatsDConfiguration>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::h507eb7431e29ea07
  [DEL] -28.1Ki  [DEL] -27.9Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::hc7701488cdaf9708
  [DEL] -30.0Ki  [DEL] -29.9Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::hd837c28d99cadabd
  [DEL] -30.5Ki  [DEL] -30.4Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::hab9dc9f6904919be
  [DEL] -30.6Ki  [DEL] -30.4Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h9fdc414799192cda
  [DEL] -30.6Ki  [DEL] -30.4Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::hc9062a2a4246a7d4
  [DEL] -38.4Ki  [DEL] -38.2Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::hadf9b85f315763cf
  [DEL] -44.0Ki  [DEL] -43.8Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h940827480ed79a43
  [DEL] -56.3Ki  [DEL] -56.2Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h49375b69dcfb6f02
  +0.0% +16.0Ki  +0.0% +6.51Ki    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: f285d874-952a-4463-bef1-3297c202d51d
Baseline: 6c175628 · Comparison: 200a5ff1 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.46	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.23	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.13	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.19	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.49	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 132 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.8 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 65 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 192 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 29 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

[datadog-datadog-prod-us1]

More details

The PR correctly adds version-gated support for otel.scope.{name,version} span metadata, emitted only when the bundled Agent is 7.82.0+ (resolved at compile time). The implementation maintains backward compatibility by always emitting deprecated otel.library.* keys. Build-time constants, proper empty-scope checks, and test coverage that mirrors the gate logic ensure both CI contexts (7.81.0 baseline and nightly) pass as intended, with no runtime regressions.

Was this helpful? React 👍 or 👎

_{📊 Validated against 12 scenarios · Open Bits AI session}

_{🤖 Datadog Autotest · Commit 200a5ff · What is Autotest? · Any feedback? Reach out in #autotest}