Add library version detection for parametric tests#1442
Conversation
c6fad41 to
9abaca3
Compare
9abaca3 to
37dde43
Compare
9a8c5f6 to
1614658
Compare
stats test cases may not result in trace requests being sent
|
Darn, there seems to be some kind of incompatibility with the Java library. An alternative approach to getting the tracer version might be to add version checks in the Test Agent interface rather than trying to do a trace request prior to the test case starting. This approach would be less invasive to the test cases. I'm going to give that a try next. |
This saves having to make separate requests to the agent which slows down the test suite.
this is done in #1442 now
|
Switching to checking the version in the test agent interface seems to have worked. It does carry the caveat that the test is only skipped at the point that data is requested from the test agent. If there are any operations performed in the test case that the library doesn't support then the test might crash/fail before it can be skipped. In the future we could have the factories of the test servers declare the version of the library that they install and use that version. The challenge there is detecting the version for dev/custom installations of libraries that run in CI/locally. |
|
LGTM - thanks Kyle! 🙇 |
|
thank's a lot @Kyle-Verhoog |
Description
As per title add version detection. This enables parametric tests to reuse the
@releaseddecorator used by other system tests.It works by retrieving the real tracer version from the library being tested by reading the http headers of requests made to the test agent.
This enables tests to be merged prior to the release of a feature.
A more accurate approach is proposed in #1445
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present