Skip to content

tests/parametric: align Go with client-stats spec#1479

Merged
ahmed-mez merged 2 commits intomainfrom
ahmed/go-client-stats
Aug 11, 2023
Merged

tests/parametric: align Go with client-stats spec#1479
ahmed-mez merged 2 commits intomainfrom
ahmed/go-client-stats

Conversation

@ahmed-mez
Copy link
Copy Markdown
Contributor

Description

Make sure client-stats computation is aligned with the spec in the Go tracer - DataDog/dd-trace-go#2168

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

Copy link
Copy Markdown
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one non-blocking suggestion, otherwise LGTM!

Comment thread tests/parametric/test_library_tracestats.py
@ahmed-mez ahmed-mez force-pushed the ahmed/go-client-stats branch from bf46ae5 to 80f3c70 Compare August 10, 2023 10:30
@ahmed-mez ahmed-mez merged commit 9f753b2 into main Aug 11, 2023
@ahmed-mez ahmed-mez deleted the ahmed/go-client-stats branch August 11, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants