Skip to content

tests/parametric: align Go with client-stats spec #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmed-mez merged 2 commits into from
Aug 11, 2023
Merged

tests/parametric: align Go with client-stats spec #1479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad0072
tests/parametric: align Go with client-stats spec
ahmed-mez Aug 9, 2023
80f3c70
depend on the go tracer version and leverage #1442
ahmed-mez Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/parametric/test_library_tracestats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ def _human_stats(stats: V06StatsAggr) -> str:

def enable_tracestats(sample_rate: Optional[float] = None) -> Any:
env = {
"DD_TRACE_STATS_COMPUTATION_ENABLED": "1", # reference, dotnet, python
Comment thread
Kyle-Verhoog marked this conversation as resolved.
"DD_TRACE_FEATURES": "discovery", # golang
"DD_TRACE_STATS_COMPUTATION_ENABLED": "1", # reference, dotnet, python, golang
"DD_TRACE_TRACER_METRICS_ENABLED": "true", # java
}
if context.library == "golang" and context.library.version < "v1.55.0":
env["DD_TRACE_FEATURES"] = "discovery"
if sample_rate is not None:
assert 0 <= sample_rate <= 1.0
env.update(
Expand Down
2 changes: 1 addition & 1 deletion utils/build/docker/golang/parametric/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
go.opentelemetry.io/otel/trace v1.16.0
google.golang.org/grpc v1.54.0
google.golang.org/protobuf v1.30.0
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230801190547-5ebe300ac718
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230808142237-30bfd5205d6a
)

require (
Expand Down
4 changes: 2 additions & 2 deletions utils/build/docker/golang/parametric/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQ
google.golang.org/protobuf v1.27.1/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
google.golang.org/protobuf v1.30.0 h1:kPPoIgf3TsEvrm0PFe15JQ+570QVxYzEvvHqChK+cng=
google.golang.org/protobuf v1.30.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230801190547-5ebe300ac718 h1:lurfzON3rJTalJlBfnsWR1aDsFGNoGgIbKAvrrP3GNI=
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230801190547-5ebe300ac718/go.mod h1:9l+gJVds2iYls2ySSNNPm842vz2clDn4eRL2uoabz2U=
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230808142237-30bfd5205d6a h1:RMV0bJU3f8/g33nmxJrHiC+l9jxOWFvU1klZSI6TiE4=
gopkg.in/DataDog/dd-trace-go.v1 v1.39.0-alpha.1.0.20230808142237-30bfd5205d6a/go.mod h1:1JqaWiPl1+vHNYuVNmHOG4HDyHbF84z98BW/hwq8FeU=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
Expand Down