Test for the exclusion of documentation modifications in library sele… - #5122
Closed
nccatoni wants to merge 7 commits into
Closed
Test for the exclusion of documentation modifications in library sele…#5122nccatoni wants to merge 7 commits into
nccatoni wants to merge 7 commits into
Conversation
darccio
added a commit
that referenced
this pull request
Aug 4, 2026
The previous commit covers CSS with the v1 protocol, but that pairing worked even while the two were coupled, so it cannot detect the coupling. The discriminating case is the mirror: v1 pinned while CSS is off. Released dd-trace-go gates v1 on CSS capability and silently downgrades to /v0.4/traces the moment stats computation is disabled. CSS is negotiated entirely out of band -- a Datadog-Client-Computed-Stats header and a separate /v0.6/stats endpoint, both handled identically by the Agent on either protocol -- so disabling it has no bearing on the trace wire format. DataDog/dd-trace-go#5122 removes the gate. Add APM_TRACING_EFFICIENT_PAYLOAD_STATS_DISABLED, which is APM_TRACING_EFFICIENT_PAYLOAD plus DD_TRACE_STATS_COMPUTATION_ENABLED =false, and Test_V1PayloadWithStatsDisabled asserting every trace still goes to /v1.0/traces in v1 format. The test first asserts no /v0.6/stats payloads exist, so it fails loudly rather than passing vacuously if CSS were somehow active. Declared missing_feature for golang until #5122 ships, and for nodejs and ruby to match every other class in this file (neither has working v1). Java is deliberately left inheriting the file-level >=1.62.0: it supports v1 when the protocol is pinned and has no CSS coupling, so it is the language that proves the test is meaningful rather than vacuous. Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
darccio
added a commit
that referenced
this pull request
Aug 7, 2026
The previous commit covers CSS with the v1 protocol, but that pairing worked even while the two were coupled, so it cannot detect the coupling. The discriminating case is the mirror: v1 pinned while CSS is off. Released dd-trace-go gates v1 on CSS capability and silently downgrades to /v0.4/traces the moment stats computation is disabled. CSS is negotiated entirely out of band -- a Datadog-Client-Computed-Stats header and a separate /v0.6/stats endpoint, both handled identically by the Agent on either protocol -- so disabling it has no bearing on the trace wire format. DataDog/dd-trace-go#5122 removes the gate. Add APM_TRACING_EFFICIENT_PAYLOAD_STATS_DISABLED, which is APM_TRACING_EFFICIENT_PAYLOAD plus DD_TRACE_STATS_COMPUTATION_ENABLED =false, and Test_V1PayloadWithStatsDisabled asserting every trace still goes to /v1.0/traces in v1 format. The test first asserts no /v0.6/stats payloads exist, so it fails loudly rather than passing vacuously if CSS were somehow active. Declared missing_feature for golang until #5122 ships, and for nodejs and ruby to match every other class in this file (neither has working v1). Java is deliberately left inheriting the file-level >=1.62.0: it supports v1 when the protocol is pinned and has no CSS coupling, so it is the language that proves the test is meaningful rather than vacuous. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ction. (#5121)
Motivation
Test for push request #5121