Skip to content

codex: pr review rules#6246

Merged
robertomonteromiguel merged 4 commits intomainfrom
robertomonteromiguel/codex_pr_review
Feb 10, 2026
Merged

codex: pr review rules#6246
robertomonteromiguel merged 4 commits intomainfrom
robertomonteromiguel/codex_pr_review

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

@robertomonteromiguel robertomonteromiguel commented Feb 9, 2026 •
edited
Loading

Motivation

Add specific rules for codex pr review

Changes

Creates a new rules file for PR review.
The new rules file is: .cursor/rules/pr-review.mdc, and is referenced from AGENTS.MD and claude.md

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

CODEOWNERS have been resolved as:

.cursor/rules/pr-review.mdc                                             @DataDog/system-tests-core
.claude/CLAUDE.md                                                       @DataDog/system-tests-core
AGENTS.md                                                               @DataDog/system-tests-core

@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review February 9, 2026 07:51
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner February 9, 2026 07:51
nccatoni
nccatoni approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nccatoni nccatoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, just a few minor comments

Comment thread AGENTS.md Outdated
Comment thread .cursor/rules/pr-review.mdc Outdated
nccatoni
nccatoni approved these changes Feb 9, 2026
View reviewed changes
Comment thread .cursor/rules/pr-review.mdc
When reviewing PRs that include changes to test activation or deactivation (manifest files or test decorators), you must verify that all modifications comply with the rules and guidelines documented in:

- [skip-tests.md](mdc:docs/edit/skip-tests.md) - When and how to use decorators vs manifests
- [manifest.md](mdc:docs/edit/manifest.md) - Manifest file format, syntax, and best practices
Copy link
Copy Markdown
Collaborator

@nccatoni nccatoni Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be moved in an AGENTS.md file in the manifests directory to apply it only to the PRs changing the manifests.

@robertomonteromiguel robertomonteromiguel merged commit 4d33c4b into main Feb 10, 2026
11 checks passed
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/codex_pr_review branch February 10, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nccatoni nccatoni nccatoni approved these changes

Assignees

No one assigned

Labels

changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertomonteromiguel @nccatoni @cbeauchesne