Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .claude/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ Read and follow these rules in EVERY interaction:
10. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts
11. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines

## Pull request review guidelines

12. **`.cursor/rules/pr-review.mdc`** - Pull Request review guidelines and checklist

---

## Quick Reference
Expand Down
20 changes: 20 additions & 0 deletions .cursor/rules/pr-review.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
description: Rules for reviewing Pull Requests in system-tests
globs:
alwaysApply: false
---
# PR Review Guidelines

## Test Activation/Deactivation Changes

When reviewing PRs that include changes to test activation or deactivation (manifest files or test decorators), you must verify that all modifications comply with the rules and guidelines documented in:

- [skip-tests.md](mdc:docs/edit/skip-tests.md) - When and how to use decorators vs manifests
- [manifest.md](mdc:docs/edit/manifest.md) - Manifest file format, syntax, and best practices
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be moved in an AGENTS.md file in the manifests directory to apply it only to the PRs changing the manifests.


Key verification points:
- Manifests are preferred over decorators when possible
- Correct format and syntax are used
- Version specifications use the `v` prefix (e.g., `v1.2.0`)
- Special YAML characters are properly quoted
- `bug` and `flaky` markers include JIRA ticket references
8 changes: 6 additions & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@ Read and follow these rules in EVERY interaction:

## Manual Rules (Apply Only When Explicitly Requested)

10. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts
11. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines
11. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts
12. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines

## Pull request review guidelines

13. **`.cursor/rules/pr-review.mdc`** - Pull Request review guidelines and checklist

---

Expand Down
Loading