Auto-activate ruby easy wins for apm-lang-platform#7043
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f11e9df1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_tracer.py::Test_TracerBaseService::test_base_service_set_when_service_overridden: missing_feature (_dd.base_service is not implemented) | ||
| tests/parametric/test_tracer.py::Test_TracerSCITagging: v1.21.0 | ||
| tests/parametric/test_tracer.py::Test_TracerServiceNameSource: v2.35.0-dev | ||
| tests/parametric/test_tracer.py::Test_TracerServiceNameSource: v2.35.0-dev # Easy win for all weblogs and version 2.34.0 |
There was a problem hiding this comment.
This line still gates Test_TracerServiceNameSource at v2.35.0-dev; per docs/edit/manifest.md, the vX.Y.Z form enables tests only for that version and newer, so Ruby 2.34.0 continues to skip this class even though the new easy-win comment says it is available for version 2.34.0. If the nightly result proved this for 2.34.0, update the declaration to a 2.34.0 range (or remove the comment) so the manifest actually activates the test.
Useful? React with 👍 / 👎.
1 participant
Automated activation of easy-win tests for
rubyowned byapm-lang-platformView nightly workflow run