adaptive sampling manifest cleanup: cpp bug entries + rust missing_feature unflagging#7224
Closed
bm1549 wants to merge 5 commits into
Closed
adaptive sampling manifest cleanup: cpp bug entries + rust missing_feature unflagging#7224bm1549 wants to merge 5 commits into
bm1549 wants to merge 5 commits into
Conversation
The bug entries in cpp.yml for five adaptive sampling tests are gated on component_version: <=1.0.0. dd-trace-cpp is on v2.1.1, so the gates never apply and the tests already run. Removing the obsolete entries to keep the manifest clean. Verified locally against dd-trace-cpp main (v2.1.1) by running the five affected tests three times -- all passed cleanly each run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Matches the format used for sibling entries like TestDynamicConfigV1_EmptyServiceTargets: ">1.0.0" and mirrors the approach taken in the Ruby PR (#6950). Preserves the historical signal that these tests were broken on cpp <=1.0.0 instead of silently deleting it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Verified locally against dd-trace-rs main (release 0.3.3) using system-tests-local. TestDynamicConfigSamplingRules:: test_trace_sampling_rules_override_env now passes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Version-gate the now-passing test rather than doing a bare activation, since CI still runs against PROD_TAG=0.3.1 and the fix landed in 0.3.3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Enables tests that now pass with the adaptive-sampling precedence fix and DD_TRACE_SAMPLE_RATE support shipped in dd-trace-rs PR #227: - TestDynamicConfigSamplingRules::test_trace_sampling_rules_override_rate - TestDynamicConfigSamplingRules::test_trace_sampling_rules_with_tags - TestDynamicConfigV1::test_trace_sampling_rate_override_env - TestDynamicConfigV1::test_trace_sampling_rate_with_sampling_rules The Rust tracer now: - Respects the documented multi-source precedence (env rules survive an RC-rate-only update; the synthetic catch-all built from tracing_sampling_rate uses default provenance, DM -3). - Parses DD_TRACE_SAMPLE_RATE as a global catch-all rate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
|
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Consolidates three adaptive-sampling manifest PRs (#6948, #6949, #7007) into one cleanup. All changes are manifest-only — no test logic or framework code touched.
Changes
manifests/cpp.yml(from #6949 + follow-up fix):bugdeclarations gated oncomponent_version: <=1.0.0for adaptive-sampling parametric tests. The C++ tracer is on v2.1.1; those gates never apply. The entries were replaced with explicit>1.0.0version gates to make the floor unambiguous.test_remote_sampling_rules_retention,test_trace_sampling_rules_override_rate,test_trace_sampling_rules_with_tags,test_trace_sampling_rate_override_env,test_trace_sampling_rate_with_sampling_rulesmanifests/rust.yml(from #6948 + #7007):TestDynamicConfigSamplingRules::test_trace_sampling_rules_override_env— now passes on dd-trace-rs >= 0.3.3; gated to>=0.3.3.missing_featureentries now that dd-trace-rs#227 landed:TestDynamicConfigSamplingRules::test_trace_sampling_rules_override_rateTestDynamicConfigSamplingRules::test_trace_sampling_rules_with_tagsTestDynamicConfigV1::test_trace_sampling_rate_override_envTestDynamicConfigV1::test_trace_sampling_rate_with_sampling_rulesWorkflow
Closes #6948, #6949. Supersedes #7007 (the rust unblock, which was draft-blocked on dd-trace-rs#227 and is now merged).
Reviewer checklist
tests/ormanifests/is modified? No — onlymanifests/cpp.ymlandmanifests/rust.ymltouched.