Skip to content

fix(asset): update access from admin to editor - #321

Merged
chasetmartin merged 2 commits into
productionfrom
hotfix/v1.1.1
Jul 30, 2026
Merged

fix(asset): update access from admin to editor#321
chasetmartin merged 2 commits into
productionfrom
hotfix/v1.1.1

Conversation

@TylerAdamMartinez

@TylerAdamMartinez TylerAdamMartinez commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • AMP editors could not access or manage unassociated assets because the resource was restricted to administrator roles.
  • Asset management permissions were tied directly to canManageAmp, which was broader than the permission needed by the attachment and asset components.
  • A patch version update is required for these changes.

How

Implementation summary - the following was changed/added/removed:

  • Updated the ocotillo.asset-unassociated access-control rules to allow editor roles to list, view, create, edit, manage, and delete unassociated assets.
  • Added canManageAssets to the access capability results, derived from canEditAmp.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • canManageAssets currently uses the same role requirement as canEditAmp, but it is exposed separately so asset permissions can be changed independently in the future.

@TylerAdamMartinez TylerAdamMartinez self-assigned this Jul 30, 2026
@TylerAdamMartinez TylerAdamMartinez added the bug Something isn't working label Jul 30, 2026
@TylerAdamMartinez
TylerAdamMartinez marked this pull request as ready for review July 30, 2026 14:48

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chasetmartin
chasetmartin merged commit 793faa0 into production Jul 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants