fix(asset): update access from admin to editor - #321
Merged
Conversation
TylerAdamMartinez
force-pushed
the
hotfix/v1.1.1
branch
from
July 30, 2026 14:20
a77e96c to
5369fff
Compare
TylerAdamMartinez
force-pushed
the
hotfix/v1.1.1
branch
from
July 30, 2026 14:43
5369fff to
f103f65
Compare
TylerAdamMartinez
marked this pull request as ready for review
July 30, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem/context:
canManageAmp, which was broader than the permission needed by the attachment and asset components.How
Implementation summary - the following was changed/added/removed:
ocotillo.asset-unassociatedaccess-control rules to allow editor roles to list, view, create, edit, manage, and delete unassociated assets.canManageAssetsto the access capability results, derived fromcanEditAmp.Notes
Any special considerations, workarounds, or follow-up work to note?
canManageAssetscurrently uses the same role requirement ascanEditAmp, but it is exposed separately so asset permissions can be changed independently in the future.