BDMS-903: Open well show pages in new windows from the well list - #325
Merged
Conversation
The well list is the entry point for comparing several wells, but every path to a detail page replaced the list in place, so users lost their scroll position and filters each time they checked one well. - Add a leading column on the well list whose cell is a link to the well show page with target="_blank". The link fills the cell so the whole column is the hit target, and being a real anchor it also supports middle click and the browser "open in new window" context menu. - Support Ctrl/Cmd+click and middle click on any ListPage row to open the record's show page in a new window. Shift is left alone because the DataGrid uses it for row range selection. - Extract buildWellShowPath so the in-app route has one definition. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Preview DeploymentPreview URL: https://preview-bdms-903-open-well-show-new-window-auejgdbofq-uc.a.run.app Note: This preview uses the staging API endpoints. |
TylerAdamMartinez
approved these changes
Aug 5, 2026
Contributor
|
Ultimately, I think the long term solution here is to implement a tab view & split view UI system within the application. |
chasetmartin
approved these changes
Aug 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes BDMS-903.
Why
AMP Team users compare several wells at a time, but every route from the well list to a well detail page replaced the list in place, so scroll position, search, and filters were lost on each round trip.
What changed
target="_blank". The link fills the whole cell, so clicking anywhere in the column opens the well in a new window — not just the icon glyph. Because it is a real anchor, middle click and the browser's own "Open link in new window" context menu work too.ListPage, so other Ocotillo list pages get it as well. Shift is deliberately untouched — the DataGrid uses it for row range selection.buildWellShowPathextracted inwellPublicUrls.tsso the in-app well route has a single definition;buildWellShowAbsoluteUrlnow builds on it.Plain left click behavior is unchanged: the row still navigates in the same tab.
Acceptance criteria
Testing
src/test/components/listPageNewWindow.test.tscover the new-window click detection and the blocked-popup path.npx vitest run src/test/{components,pages,utils}— 214 passed./ocotillo/well/show/:idwithtarget="_blank" rel="noopener noreferrer"and anOpen <well name> in a new windowaria-label; Ctrl+click on a row callswindow.open(...,'_blank','noopener,noreferrer')while a plain click still navigates in place; the link rect covers the full cell.🤖 Generated with Claude Code