Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
approved these changes
Oct 17, 2024
Collaborator
shangyian
left a comment
shangyian
left a comment
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to pass the
lookback_windowdown to the query service calls. This PR does it...Made a dev version at https://pypi.org/project/datajunction-server/0.0.1a70.dev0
Test Plan
Tested locally and made sure the lookback_window is passed on.
make checkpassesmake testshows 100% unit test coverageDeployment Plan
auto