Skip to content

Add lookback window to Materialization calls. #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agorajek merged 1 commit into from
Oct 17, 2024
Merged

Add lookback window to Materialization calls. #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datajunction-server/datajunction_server/materialization/jobs/cube_materialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def schedule(
partitions=temporal_partition + categorical_partitions,
job=materialization.job,
strategy=materialization.strategy,
lookback_window=cube_config.lookback_window,
),
request_headers=request_headers,
)
Expand Down
1 change: 1 addition & 0 deletions datajunction-server/datajunction_server/models/materialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ class GenericMaterializationInput(BaseModel):
spark_conf: Optional[Dict] = None
partitions: Optional[List[Dict]] = None
columns: List[ColumnMetadata]
lookback_window: Optional[str] = "1 DAY"


class DruidMaterializationInput(GenericMaterializationInput):
Expand Down
2 changes: 2 additions & 0 deletions datajunction-server/tests/service_clients_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ def test_query_service_client_materialize(self, mocker: MockerFixture) -> None:
"spark_conf": {},
"upstream_tables": ["default.hard_hats"],
"columns": [],
"lookback_window": "1 DAY",
},
headers=ANY,
)
Expand Down Expand Up @@ -544,6 +545,7 @@ def test_materialize(self, mocker: MockerFixture) -> None:
json={
"name": "default",
"job": "SparkSqlMaterializationJob",
"lookback_window": "1 DAY",
"strategy": "full",
"node_name": "default.hard_hat",
"node_version": "v1",
Expand Down