Skip to content

Fix broken link to Explorer from pre-aggregations tab#1953

Merged
shangyian merged 2 commits intomainfrom
fix-planner-page-link
Apr 3, 2026
Merged

Fix broken link to Explorer from pre-aggregations tab#1953
shangyian merged 2 commits intomainfrom
fix-planner-page-link

Conversation

@valgee
Copy link
Copy Markdown
Collaborator

@valgee valgee commented Apr 3, 2026

Summary

The link in the pre-aggregations tab on transform node pages pointed to /query-planner, which no longer exists after the page was renamed. This was causing a 404 for anyone clicking through to plan materializations.

  • Updated the link href from /query-planner/planner
  • Updated the link text from "Query Planner" → "Explorer" to match the UI label
  • Improved empty state copy in the pre-aggregations tab
  • Updated the MemoryRouter route path in QueryPlannerPage tests to reflect the correct route

Test plan

  • Navigate to a transform node page → Materializations tab → click the Explorer link → confirm it lands correctly
  • CI=true npm test passes

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit a8caff3
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/69d03e26ec17470008b53920

@valgee valgee requested a review from shangyian April 3, 2026 22:40
Copy link
Copy Markdown
Collaborator

@shangyian shangyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the fix! 🥳

@shangyian shangyian merged commit cf45e26 into main Apr 3, 2026
17 checks passed
@shangyian shangyian deleted the fix-planner-page-link branch April 3, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants