Skip to content

Fix broken link to Explorer from pre-aggregations tab #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shangyian merged 2 commits into from
Apr 3, 2026
Merged

Fix broken link to Explorer from pre-aggregations tab #1953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c508cd
Fix planner page link
Apr 3, 2026
a8caff3
Improve empty state copy in pre-aggregations tab
Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions datajunction-ui/src/app/pages/NodePage/NodePreAggregationsTab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,8 @@ export default function NodePreAggregationsTab({ node }) {
No pre-aggregations found for this node.
</div>
<p className="preagg-no-data-text">
Pre-aggregations are created when you use the{' '}
<a href="/query-planner">Query Planner</a> to plan materializations
for metrics derived from this node.
Visit <a href="/planner">Explorer</a> to plan materializations for
metrics derived from this node.
</p>
</div>
);
Expand Down
12 changes: 6 additions & 6 deletions datajunction-ui/src/app/pages/QueryPlannerPage/__tests__/index.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@ const mockCubeData = {
},
};

const renderPage = (initialEntries = ['/query-planner']) => {
const renderPage = (initialEntries = ['/planner']) => {
return render(
<MemoryRouter initialEntries={initialEntries}>
<Routes>
<Route
path="/query-planner"
path="/planner"
element={
<DJClientContext.Provider value={{ DataJunctionAPI: mockDjClient }}>
<QueryPlannerPage />
Expand Down Expand Up @@ -384,7 +384,7 @@ describe('QueryPlannerPage', () => {
mockDjClient.cubeForPlanner.mockResolvedValue(mockCubeData);

renderPage([
'/query-planner?metrics=default.num_repair_orders,default.avg_repair_price',
'/planner?metrics=default.num_repair_orders,default.avg_repair_price',
]);

await waitFor(() => {
Expand All @@ -395,7 +395,7 @@ describe('QueryPlannerPage', () => {
it('initializes from URL with cube parameter', async () => {
mockDjClient.cubeForPlanner.mockResolvedValue(mockCubeData);

renderPage(['/query-planner?cube=default.test_cube']);
renderPage(['/planner?cube=default.test_cube']);

await waitFor(() => {
expect(mockDjClient.cubeForPlanner).toHaveBeenCalledWith(
Expand Down Expand Up @@ -1489,7 +1489,7 @@ describe('QueryPlannerPage', () => {
// cubeForPlanner returns data without cube_node_metrics array
mockDjClient.cubeForPlanner.mockResolvedValue({ name: 'bad.cube' });

renderPage(['/query-planner?cube=bad.cube']);
renderPage(['/planner?cube=bad.cube']);

await waitFor(() => {
expect(mockDjClient.cubeForPlanner).toHaveBeenCalledWith('bad.cube');
Expand All @@ -1502,7 +1502,7 @@ describe('QueryPlannerPage', () => {
it('handles cubeForPlanner throwing during URL init', async () => {
mockDjClient.cubeForPlanner.mockRejectedValue(new Error('Network error'));

renderPage(['/query-planner?cube=bad.cube']);
renderPage(['/planner?cube=bad.cube']);

await waitFor(() => {
expect(mockDjClient.cubeForPlanner).toHaveBeenCalled();
Expand Down
Loading