Fix concurrent session crash in GraphQL multi-field queries#2024
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Apr 19, 2026
Merged
Fix concurrent session crash in GraphQL multi-field queries#2024shangyian merged 1 commit intoDataJunction:mainfrom
shangyian merged 1 commit intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphQL resolvers shared a single
AsyncSessionviainfo.context["session"]. Strawberry resolves top-level fields concurrently, so a query like{ findNodes(...) searchTags(...) }would fire twoawait session.execute()calls on the same session simultaneously, causing anInvalidCachedStatementErrorlike "concurrent operations are not permitted". This was a latent bug in all resolvers and could be triggered by a client sending multiple top-level fields in one request.Each resolver now creates its own session via
resolver_session(info), a new helper in that wrapssession_context(request). DataLoaders already used independent sessions and are unaffected.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan