Fix resolver session to create independent sessions#2028
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Apr 19, 2026
Merged
Fix resolver session to create independent sessions#2028shangyian merged 1 commit intoDataJunction:mainfrom
shangyian merged 1 commit intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous fix (#2024) replaced
info.context["session"]withresolver_session()in all GraphQL resolvers, butresolver_sessiondelegated tosession_context()which returnsrequest.state.test_sessionand is set byget_contexton every request, not just for tests. This meant all resolvers still shared one session in production, and the concurrent-session crash persisted.This now calls
get_session()directly in production, only reusing the shared session in tests (detected via dependency_overrides).Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan