Speed up GraphQL findNodes via batched extract#2049
Merged
shangyian merged 1 commit intoDataJunction:mainfrom Apr 24, 2026
Merged
Speed up GraphQL findNodes via batched extract#2049shangyian merged 1 commit intoDataJunction:mainfrom
shangyian merged 1 commit intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
…st-path resolver for derived expression, conditional metric metadata AST parse
cf40abd to
ea79599
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cuts
findNodes(nodeTypes: [METRIC])wall-clock from ~14s to ~1s on a 1000-metric fragment that readsextractedMeasures,metricMetadata, andcolumns. The resolver now serves the common case from denormalized columns instead of parsing and extracting per-metric on every request.extractedMeasuresonly readsderivedQuery, returnNodeRevision.derived_expression(which gets populated by thederive_frozen_measuresbackground task on node create/update) and skipMetricComponentExtractor.extract(). This reduces the number of ANTLR parses and AST walks.derivedExpressionalias is requested. When the full path is needed, a request-scoped loader batches N per-metric extractions into one session.joinedload(Column.dimension/partition), which are alreadylazy="joined"on the relationship and were causing cartesian row fanout during hydration.metricMetadataAST parse. Skip the ANTLR parse + function walk unless the fragment requestsexpressionorincompatibleDruidFunctions.Also added a backfill scrip that populates
derived_expressionfor metrics created beforederive_frozen_measuresexisted, so they hit the fast path after deploy.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan