Populate derived expression and frozen measures during deployment#2050
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Apr 24, 2026
Merged
Populate derived expression and frozen measures during deployment#2050shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
723c5fe to
c8dbfc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metrics created or updated through
/deploymentsnow have theirderived_expressionandFrozenMeasurerows populated atomically with the rest of the deployment, closing a gap where only the single-node create/update paths scheduled this metadata derivation as a background task.Bulk-deployed metrics previously landed with
derived_expression = NULL, which forced every GraphQL read (see this recent change #2049) to re-run metric component extraction.The orchestrator now includes a "derive measures" phase inside the deployment savepoint (committed on wet-run, rolled back on dry-run), so derivation shares the atomicity guarantees of the rest of the deployment. The new
derive_frozen_measures_bulkbatches DB work viaMetricComponentExtractor's existing cache params, collapsing what would have been N × (2 + avg measures) queries per deployment into ~2 queries (one to load all target revisions + parent chain, one to pre-fetch existing frozen measure rows by name).Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan