Remove parsed-AST cache from bulk metric derivation#2055
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Apr 24, 2026
Merged
Remove parsed-AST cache from bulk metric derivation#2055shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the frozen measures storage change in #2050, deployments could cause errors like:
This is because
derive_frozen_measures_bulkwas passing a shared query cache intoMetricComponentExtractor.extract, which returned deepcopy views of cached query ASTs. BecauseFunction.__deepcopy__returnsself, Function nodes ended up shared across copies with stale parent back-pointers, and_extract_basecrashed atfunc.parent.replace(from_=func, to=...)during any deployment that touched metrics.The fix drops the cache entirely: extract now always calls
parse(query)fresh, which yields an AST with intact parent pointers. Re-parsing per metric is cheap relative to the DB work the bulk path already avoids.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan