Add deploy-path test coverage for external pre-agg dimension_columns#2365
Merged
shangyian merged 2 commits intoJul 25, 2026
Merged
Conversation
The dimension_columns mapping for externally-registered pre-aggregations (DataJunction#2360) was only exercised through the POST /preaggs/register API path. The deployment/orchestrator path — what `dj push` actually uses — had no coverage. This adds a deployment-path test asserting that a pre-agg declared with dimension_columns binds each grain dimension to its physical column and that the generated measures SQL reads the mapped physical column (aliased back to the DJ name) instead of the DJ dimension name. It covers the two shapes a real external agg hits: a joined dimension's key satisfied by a differently-named parent foreign-key column, and a local fact column. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
marked this pull request as ready for review
July 25, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dimension_columnsmapping for externally-registered pre-aggregations (#2360) was only exercised through the POST /preaggs/register API path. The deployment/orchestrator path (used bydj push) had no coverage.This adds a deployment-path test asserting that a pre-agg declared with dimension_columns binds each grain dimension to its physical column and that the generated measures SQL reads the mapped physical column (aliased back to the DJ name) instead of the DJ dimension name. It covers the two shapes a real external agg hits: a joined dimension's key satisfied by a differently-named parent foreign-key column, and a local fact column.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan