Feat / Extending ImageColumn with ->preview() #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
SlimDeluxe
requested changes
Sep 16, 2025
Member
There was a problem hiding this comment.
- Please separate the CSS and JS into their own asset files and register them with Filament.
https://filamentphp.com/docs/3.x/support/assets - Instead of using a macro, create a new column class that extends the ImageColumn class (use the same name for the class, just the namespace is different). Place it in
src/Filament/Tables/Columns. "Preview" can then be a method with proper parameters that will get hinted when writing the column definition.
added 5 commits
September 18, 2025 07:55
…le & adding another reusable component here
… refactor/image-lightbox
SlimDeluxe
requested changes
Sep 18, 2025
Member
SlimDeluxe
left a comment
SlimDeluxe
left a comment
There was a problem hiding this comment.
Please see below for required changes
Member
|
After the changes, a fix will be required in DataLinx/eclipsephp-catalogue-plugin#28 |
Contributor
Author
|
@SlimDeluxe Should be good to review this |
Contributor
Author
|
@SlimDeluxe This got closed by mistake. And I think we should wait until we migrate the project to F4 before we merge this. |
Contributor
Author
|
@SlimDeluxe So I am converting this to draft. |
Contributor
Author
|
@SlimDeluxe since we won't be merging F4 anytime soon so maybe this can be reviewed & merged. |
SlimDeluxe
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket