You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is 29% slower operation, according to my benchmark runs.
Does this measuremetn include GC-time?
My experience says that GC is one of main factors of performances.
So I have a bias to save more memory at the cost of CPU cycles
No, it doesn't, I wanted to know what is pure operations cost.
So I have a bias to save more memory at the cost of CPU cycles.
Not always, we know it :)
OK, lets not have the field.
Since a Node is created less frequent than checked for its TextNodeness during conversion to command text :) I wanted to cache this info to improve translation because it happens a lot of times for cached queries, it reduces translation overhead for a bit for the cost of size of this field. This was my thoughts, to me faster queries are important, little bit here, little bit there and we have some significant value :)
If this is ok for you highly loaded app then I agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially is saves megabytes