Skip to content

Save 8/4 bytes per node instance. Use is operator instead of bool field #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-kulakov merged 1 commit into from
Aug 17, 2023
Merged

Save 8/4 bytes per node instance. Use is operator instead of bool field #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Orm/Xtensive.Orm/Sql/Compiler/Internals/Nodes/ContainerNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public void Add(Node node)
{
FlushBuffer();
children.Add(node);
lastNodeIsText = node.IsTextNode;
lastNodeIsText = node is TextNode;
}

internal override void AcceptVisitor(NodeVisitor visitor)
Expand Down
13 changes: 1 addition & 12 deletions Orm/Xtensive.Orm/Sql/Compiler/Internals/Nodes/Node.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,6 @@ namespace Xtensive.Sql.Compiler
/// </summary>
public abstract class Node
{
internal readonly bool IsTextNode;

internal abstract void AcceptVisitor(NodeVisitor visitor);

public Node()
{
}

internal Node(bool isTextNode)
{
IsTextNode = isTextNode;
}
}
}
}
1 change: 0 additions & 1 deletion Orm/Xtensive.Orm/Sql/Compiler/Internals/Nodes/TextNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ internal override void AcceptVisitor(NodeVisitor visitor)
// Constructor

public TextNode(string text)
: base(true)
{
Text = text;
}
Expand Down