No GetGenericMethodDefinition method calls #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate GetGenericMethodDefinition method call in MemberCompilerProvider class
…d to thread contention and to lock convoy issue (#16)
alex-kulakov
previously approved these changes
Sep 10, 2020
alex-kulakov
changed the title
alex-kulakov
approved these changes
Sep 10, 2020
alex-kulakov
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Session.WithTag() method() * Use Scoped TagContext for tagging * Tag query with all nested TagContexts * Minor improvement * Null check * Make TagContext constructor internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to eliminate
GetGenericMethodDefinitioncalls on hot paths because it leads to lock contention under high load.'GetGenericMethodDefinition' calls 'System.RuntimeType.GetMethodBase' under the hood and this method in turn may cause lock contention (See dotnet/runtime#35851 for details).