Skip to content

Fixes a number of bugs related to charts and tables, modifies sharing feature#360

Merged
jasonlally merged 15 commits intodevelopfrom
fix/chart-layout
Aug 2, 2017
Merged

Fixes a number of bugs related to charts and tables, modifies sharing feature#360
jasonlally merged 15 commits intodevelopfrom
fix/chart-layout

Conversation

@jasonlally
Copy link
Copy Markdown
Collaborator

@jasonlally jasonlally commented Aug 1, 2017

What it does

PR addresses one feature change

  • Moves the link sharing snippet into a modal overlay (embed will live here as well when it's ready)

And several QA changes:

  • Change ariaHidden -> aria-hidden
  • Sets absolute offsets for charts and table
  • Sets table to fill available height minus a portion for pagination (this is all just for now, table will get replaced with more robust react-virtualized in future release)
  • A brute-force fix to the geometry types breaking the tables, for now display nothing, later will output as WKT, but not worrying about this until we refactor the table
  • Removed some cruft from actions, reducers and initialState settings
  • Added reducers to reset state for the Table, Query and Metadata when loading a new dataset

Screenshots

Share options are now in an overlay modal.

screen shot 2017-08-02 at 9 13 51 am

@jasonlally jasonlally merged commit de1c3f5 into develop Aug 2, 2017
@jasonlally jasonlally changed the title WIP: Fixes a number of related issues Fixes a number of bugs related to charts and tables, modifies sharing feature Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant