Skip to content

fix: Set compaction on upsert topics in Kafka config - #2184

Merged
ferenc-csaky merged 3 commits into
mainfrom
fix/kafka_topic_compaction
Jul 2, 2026
Merged

fix: Set compaction on upsert topics in Kafka config#2184
ferenc-csaky merged 3 commits into
mainfrom
fix/kafka_topic_compaction

Conversation

@mbroecheler

@mbroecheler mbroecheler commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

upserted topics should be compacted.

Also fixes a small doc string bug.

@mbroecheler
mbroecheler requested a review from ferenc-csaky July 2, 2026 04:30
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.95%. Comparing base (b72db80) to head (92ae2f7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...abase/relational/AbstractJdbcStatementFactory.java 0.00% 1 Missing ⚠️
.../com/datasqrl/engine/log/kafka/KafkaLogEngine.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2184      +/-   ##
============================================
- Coverage     15.95%   15.95%   -0.01%     
  Complexity     1016     1016              
============================================
  Files           619      619              
  Lines         17925    17927       +2     
  Branches       2193     2193              
============================================
  Hits           2860     2860              
- Misses        14782    14784       +2     
  Partials        283      283              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky ferenc-csaky changed the title fix: et compaction on upsert topics in kafka config fix: Set compaction on upsert topics in Kafka config Jul 2, 2026
@ferenc-csaky ferenc-csaky added the bug Something isn't working label Jul 2, 2026
@ferenc-csaky ferenc-csaky added this to the 0.10.8 milestone Jul 2, 2026
@ferenc-csaky
ferenc-csaky merged commit bd46a5d into main Jul 2, 2026
18 checks passed
@ferenc-csaky
ferenc-csaky deleted the fix/kafka_topic_compaction branch July 2, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants