Skip to content

feat: Make IMPORT and EXPORT path elements escapable - #2185

Merged
ferenc-csaky merged 1 commit into
mainfrom
feat/escapable-import+export
Jul 2, 2026
Merged

feat: Make IMPORT and EXPORT path elements escapable#2185
ferenc-csaky merged 1 commit into
mainfrom
feat/escapable-import+export

Conversation

@ferenc-csaky

Copy link
Copy Markdown
Collaborator

Key Changes

  • Call stripQuotes when we create a Name instance
  • Updated DAG a planner test case and a usecase test to cover the added functionality
  • Removed some dead code
  • Some refactor to use string libs instead of replicating the same functionality in our repo

@ferenc-csaky
ferenc-csaky requested a review from mateczagany July 2, 2026 12:24
@ferenc-csaky ferenc-csaky added the enhancement New feature or request label Jul 2, 2026
@ferenc-csaky ferenc-csaky added this to the 0.10.8 milestone Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.94%. Comparing base (b72db80) to head (660bd7a).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...in/java/com/datasqrl/loaders/ModuleLoaderImpl.java 0.00% 6 Missing ⚠️
...m/datasqrl/planner/util/SqlTableNameExtractor.java 33.33% 1 Missing and 1 partial ⚠️
...in/java/com/datasqrl/planner/SqlScriptPlanner.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2185      +/-   ##
============================================
- Coverage     15.95%   15.94%   -0.02%     
+ Complexity     1016     1014       -2     
============================================
  Files           619      618       -1     
  Lines         17925    17899      -26     
  Branches       2193     2189       -4     
============================================
- Hits           2860     2854       -6     
+ Misses        14782    14764      -18     
+ Partials        283      281       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky ferenc-csaky changed the title feat: Make IMORT and EXPORT path elements escapable feat: Make IMPORT and EXPORT path elements escapable Jul 2, 2026
@ferenc-csaky
ferenc-csaky merged commit f624591 into main Jul 2, 2026
19 of 20 checks passed
@ferenc-csaky
ferenc-csaky deleted the feat/escapable-import+export branch July 2, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants