test: backfill transport/logging/cli coverage#34
Merged
Conversation
Wave 3 of the engineering-health backlog. Pure test-backfill: no production code changed. The suite stays offline and key-free. - tests/test_transport.py (8 tests): drive the real post_json through an httpx.MockTransport mounted on the pooled client -- success/decoded JSON, error-status JSON returned-not-raised, non-JSON text fallback, timeout and connect-error -> leak-free TransportError, client reuse/pooling, rebuild after close, aclose idempotency. transport.py 58% -> 100%. - tests/test_logging.py (5 tests): CONCLAVE_LOG_LEVEL resolution (default WARNING, case-insensitive, unknown -> WARNING), root-vs-child factory contract, one-shot configuration (no handler stacking). - tests/test_cli.py (+7 tests): human renderers (synthesize/raw/debate/ adversarial), skipped-no-key warning, and the providers table (asserts the key value never prints). cli.py 43% -> 89%. TOTAL coverage 86% -> 94%; 102 -> 121 tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18
Wave 3 test-backfill. No production code changed; suite stays offline and key-free.
Per-module coverage (before → after):
Tests added:
102 → 121 tests passing.