Skip to content

Drop the exports entry for the deleted http-security module - #328

Merged
aamoghS merged 1 commit into
mainfrom
chore/drop-dangling-export
Aug 9, 2026
Merged

Drop the exports entry for the deleted http-security module#328
aamoghS merged 1 commit into
mainfrom
chore/drop-dangling-export

Conversation

@aamoghS

@aamoghS aamoghS commented Aug 9, 2026

Copy link
Copy Markdown
Member

Loose end from the adversarial review of #325.

That PR deleted packages/api/src/middleware/http-security.ts and left "./middleware/http-security" in the package exports map — so the specifier the manifest advertises resolves to a file that is not there. Nothing imports it, nothing is broken today; this removes the trap for whoever writes that import next.

Three entries were already dangling before this work./middlewaresrc/middleware.ts, ./clientsrc/client.ts, ./trpc-serversrc/trpc-server.ts. All three point at files that do not exist. I have left them alone: they predate this stack and removing them is a separate call, not mine to make in a cleanup PR. Worth a look though.

typecheck · 426 tests · lint --max-warnings 0 · build.


Note

Low Risk
Manifest-only cleanup with no runtime or import changes; risk is negligible.

Overview
Removes the "./middleware/http-security" entry from @query/api’s package.json exports map after http-security.ts was deleted in a prior change.

Without this, the manifest still advertises a subpath that resolves to a missing file—nothing in the repo imports it today, but the export is a trap for the next @query/api/middleware/http-security import.

Other dangling export keys noted in the PR description (./middleware, ./client, ./trpc-server) are unchanged here.

Reviewed by Cursor Bugbot for commit 4bd743e. Bugbot is set up for automated code reviews on this repo. Configure here.

#325 deleted packages/api/src/middleware/http-security.ts and left its subpath
in the package exports map, so `@query/api/middleware/http-security` — the
specifier the manifest says is valid — resolves to a file that is not there.
Nothing imports it, so nothing is broken today; this only removes the trap.

Three entries were already dangling before this: ./middleware, ./client and
./trpc-server all point at files that do not exist. Left alone deliberately —
they predate this work and removing them is a separate decision — but they are
worth a look.

Verified: typecheck, 426 tests, lint --max-warnings 0, build.
@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fd99a6d7-66e9-4969-9598-932a2254cf22)

@github-actions github-actions Bot added the chore label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 4bd743e):

https://hacklytics2027--pr-328-5xypfvpp.web.app

(expires Sun, 16 Aug 2026 03:05:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c48ba34db61581e25fe2978355160b5eefe0e83f

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes a stale package export for the previously deleted HTTP security middleware.

  • Removes ./middleware/http-security from the @query/api exports map.
  • Leaves unrelated, pre-existing dangling exports unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it removes an unusable export without affecting any current repository consumer.

The removed subpath pointed to an already deleted module, while repository source, tests, fixtures, configuration, and documentation contain no imports of that subpath.

Important Files Changed

Filename Overview
packages/api/package.json Removes an export whose target file no longer exists; no current repository consumer references the removed subpath.

Reviews (1): Last reviewed commit: "chore(api): drop the exports entry for t..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant