Drop the last points fixture - #330
Conversation
D4 removed event.points_value, but this club-event fixture still set it. Dead data rather than a failure — the fixture is a plain object handed to a mock, not typed against the schema — but it reads as though club events still carry points, which is exactly the impression D4 set out to remove. Verified: typecheck, 426 tests, lint --max-warnings 0, build.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_dfad1e38-f456-4b7d-b63c-d7eff69feebe) |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Visit the preview URL for this PR (updated for commit 48a3cbe): https://hacklytics2027--pr-330-u49ingaf.web.app (expires Sun, 16 Aug 2026 03:14:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
|
| Filename | Overview |
|---|---|
| packages/api/src/.internal-tests/qr-checkin.test.ts | Safely removes an unused fixture property that no longer exists in the event schema. |
Reviews (1): Last reviewed commit: "chore(tests): drop the last points fixtu..." | Re-trigger Greptile
Last leftover from D4 (#325), found by grepping
mainfor the removed columns.event.points_valueis gone from the schema, but a club-event test fixture still setpointsValue: 10. Dead data rather than a failure — the fixture is a plain object handed to a mock, not typed against the schema — but it reads as though club events still carry points, which is the exact impression D4 set out to remove.typecheck · 426 tests · lint
--max-warnings 0· build.Note
Low Risk
Test-only fixture cleanup with no runtime or schema impact.
Overview
Removes
pointsValue: 10from theclubEventhelper in the QR check-in internal tests. That field belonged to the oldevent.points_valuecolumn dropped in D4 (#325); the mock fixture was never schema-typed, so tests still passed, but the leftover property made club events look like they still carried points.Reviewed by Cursor Bugbot for commit 48a3cbe. Bugbot is set up for automated code reviews on this repo. Configure here.