Skip to content

Drop the last points fixture - #330

Merged
aamoghS merged 1 commit into
mainfrom
chore/drop-points-fixture
Aug 9, 2026
Merged

Drop the last points fixture#330
aamoghS merged 1 commit into
mainfrom
chore/drop-points-fixture

Conversation

@aamoghS

@aamoghS aamoghS commented Aug 9, 2026

Copy link
Copy Markdown
Member

Last leftover from D4 (#325), found by grepping main for the removed columns.

event.points_value is gone from the schema, but a club-event test fixture still set pointsValue: 10. Dead data rather than a failure — the fixture is a plain object handed to a mock, not typed against the schema — but it reads as though club events still carry points, which is the exact impression D4 set out to remove.

typecheck · 426 tests · lint --max-warnings 0 · build.


Note

Low Risk
Test-only fixture cleanup with no runtime or schema impact.

Overview
Removes pointsValue: 10 from the clubEvent helper in the QR check-in internal tests. That field belonged to the old event.points_value column dropped in D4 (#325); the mock fixture was never schema-typed, so tests still passed, but the leftover property made club events look like they still carried points.

Reviewed by Cursor Bugbot for commit 48a3cbe. Bugbot is set up for automated code reviews on this repo. Configure here.

D4 removed event.points_value, but this club-event fixture still set it. Dead
data rather than a failure — the fixture is a plain object handed to a mock,
not typed against the schema — but it reads as though club events still carry
points, which is exactly the impression D4 set out to remove.

Verified: typecheck, 426 tests, lint --max-warnings 0, build.
@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_dfad1e38-f456-4b7d-b63c-d7eff69feebe)

@github-actions github-actions Bot added the chore label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 48a3cbe):

https://hacklytics2027--pr-330-u49ingaf.web.app

(expires Sun, 16 Aug 2026 03:14:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c48ba34db61581e25fe2978355160b5eefe0e83f

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the obsolete pointsValue property from the club-event test fixture, aligning it with the current event schema.

  • Cleans up dead fixture data left after removal of event points columns.
  • Does not change production behavior or test expectations.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The removed property is unused by the fixture’s consumers and absent from the current event schema, so the change only eliminates stale test data.

Important Files Changed

Filename Overview
packages/api/src/.internal-tests/qr-checkin.test.ts Safely removes an unused fixture property that no longer exists in the event schema.

Reviews (1): Last reviewed commit: "chore(tests): drop the last points fixtu..." | Re-trigger Greptile

@aamoghS
aamoghS merged commit 2a7fe0f into main Aug 9, 2026
14 checks passed
@aamoghS
aamoghS deleted the chore/drop-points-fixture branch August 9, 2026 03:15
@aamoghS aamoghS mentioned this pull request Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant