Skip to content

A blank graduation year no longer blocks saving the profile #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aamoghS merged 3 commits into from
Aug 9, 2026
+5 −1
Merged

A blank graduation year no longer blocks saving the profile #335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3caaf6
fix(portal): a blank graduation year no longer blocks saving the profile
aamoghS Aug 9, 2026
7937061
Merge remote-tracking branch 'origin/main' into fix/profile-save-blocked
github-actions[bot] Aug 9, 2026
091c567
Merge remote-tracking branch 'origin/main' into fix/profile-save-blocked
github-actions[bot] Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sites/mainweb/components/portal/MembershipTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,14 @@ export function MembershipTab() {
const save = () => {
setError(null);

// `null` is a graduation year that was left blank, which is allowed and is
// what clears the column. The guard compared against `undefined` instead,
// so `Number.isInteger(null)` failed it and the whole form refused to save
// — school, skills, socials and all — until a year was typed in.
const year = form.graduationYear.trim()
? Number(form.graduationYear)
: null;
if (year !== undefined && !Number.isInteger(year)) {
if (year !== null && !Number.isInteger(year)) {
setError("That graduation year does not look right.");
return;
}
Expand Down