Skip to content

Restore the Table Cards tab — judging cannot start without it - #338

Merged
aamoghS merged 1 commit into
mainfrom
fix/restore-table-cards
Aug 9, 2026
Merged

Restore the Table Cards tab — judging cannot start without it#338
aamoghS merged 1 commit into
mainfrom
fix/restore-table-cards

Conversation

@aamoghS

@aamoghS aamoghS commented Aug 9, 2026

Copy link
Copy Markdown
Member

Blocker. Judges score by scanning the QR on a team's table card: the scoring form on /hackathons/[id]/judge only opens once startByQrCode succeeds. TableCards.tsx renders those printable cards and is the only consumer of judge.tableCards — and nothing imported it. No card could be printed, so no judge could open the form, so judging could not start at all. The only workaround was reading judging_project.qr_code out of the database and generating QRs elsewhere.

This is mine: when I split the work into a stack, branch 1 took the pre-stack version of admin/hackathons/[id]/page.tsx, so the Table Cards tab and its import never reached main — and the W24 mobile-nav fix went with it (seven tabs in a five-column grid, Table Cards and Email laid out off the right edge of the phone an organiser actually carries). Both restored here.

Worth noting how invisible it was: the component still compiled, all 426 tests still passed, and no gate could see that a tab had gone missing. It surfaced from walking the organiser and judge journeys end to end against main.

typecheck · 426 tests · lint --max-warnings 0 · build.


Note

Medium Risk
Restores a critical organiser judging workflow (printable QR table cards) and changes mobile admin navigation layout; no auth or data-model changes, but missing the tab was a production blocker for judging.

Overview
Restores the admin Table Cards tab so organisers can print desk QR cards again — the only UI wired to judge.tableCards and required for judges to open the scoring form via startByQrCode.

Adds the Table Cards nav entry (QrCode icon), extends the Tab union with tables, and mounts TableCards in the main content area when that tab is active.

Fixes mobile bottom navigation for seven tabs: replaces a fixed grid-cols-5 layout with a horizontally scrollable row (flex overflow-x-auto, hidden scrollbar) and shrink-0 basis-1/5 tab buttons so Table Cards and Email are reachable on phones instead of clipped off-screen.

Reviewed by Cursor Bugbot for commit 49e8c9d. Bugbot is set up for automated code reviews on this repo. Configure here.

…t it

Judges score by scanning the QR on a team's table card: the scoring form only
opens after startByQrCode succeeds. TableCards.tsx renders those cards and is
the only consumer of judge.tableCards — and nothing imported it, so no card
could be printed and no judge could open the form. Judging was unstartable.

Lost when I split this work into a stack: branch 1 took the pre-stack version
of this page, so the tab and its import never reached main, and the mobile-nav
fix (seven tabs in a five-column grid, with Table Cards and Email laid out off
the right edge of the phone) went with it. Both are restored here.

Found by walking the organiser and judge journeys against main. Nothing failed
— the component compiled, 426 tests passed, and the missing tab was invisible
to all of it.
@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_c1391e65-6df7-4fdc-9cef-d3a812219cda)

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 49e8c9d):

https://hacklytics2027--pr-338-bho9v9wt.web.app

(expires Sun, 16 Aug 2026 05:26:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c48ba34db61581e25fe2978355160b5eefe0e83f

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown

Greptile Summary

Restores access to printable table cards from the hackathon administration dashboard and updates the mobile tab bar so all seven administration tabs remain reachable.

  • Adds the Table Cards tab, icon, component import, and conditional content rendering.
  • Replaces the five-column mobile grid with a horizontally scrollable navigation bar.

Confidence Score: 5/5

The PR appears safe to merge, with the restored table-card workflow and mobile navigation integrated consistently with the existing dashboard.

The TableCards export, client boundary, prop contract, authorization, and query wiring match the new call site, while the mobile navigation explicitly provides horizontal overflow for all seven fixed-width tabs.

Important Files Changed

Filename Overview
sites/mainweb/app/(portal)/admin/hackathons/[id]/page.tsx Correctly integrates the existing TableCards component and makes the expanded mobile tab list horizontally scrollable without an identified regression.

Reviews (1): Last reviewed commit: "fix(admin): restore the Table Cards tab ..." | Re-trigger Greptile

@aamoghS
aamoghS merged commit ec28119 into main Aug 9, 2026
14 checks passed
@aamoghS
aamoghS deleted the fix/restore-table-cards branch August 9, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant