fix(v0.1.10): code review follow-ups (PRs #147/#149) + release prep - #152
Conversation
…view) ai_hint() pointed every failed ingestion and dbt test at the removed 'tycoon ask chat'; observability scaffold suggested 'tycoon ask sync'. Also drops the dead nao_dir config property, the scaffolded .gitignore nao entries, and stale Nao mentions in comments/docstrings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…sert quack port (PR #147 review) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…coverage floor to 68 - pandas==3.0.3, pinned like every other core dep; nothing in src/ imports it but dlt's on-demand filesystem source needs it for CSV reads (tests/test_e2e_demo_arc.py proves it). Extra treatment: #148. - Coverage floor: deleting the untested server/dagster code lifted real coverage to ~73%, so the floor moves UP to 68 (5-point drift headroom, same margin as the old 65/60 split) — not down to 55. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- CHANGELOG [0.1.10] UNRELEASED section + docs/releases/v0.1.10.md (Released: TBD — date flips at ship time per release procedure) - mkdocs nav gains the v0.1.10 release entry Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project to version 0.1.10, focusing on streamlining the codebase by removing the FastAPI web UI, Dagster orchestration, and the Nao/ask AI agent. It introduces the MetadataBackend protocol with a DuckDB file backend, pins pandas as a core dependency, updates the test coverage floor to 68%, and removes stale AI-agent hints and references across commands, configuration, and templates. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request prepares the codebase for the v0.1.10 release, focusing on a major cleanup ("the great slimming"). It removes the FastAPI web UI, Dagster orchestration, and the Nao/ask AI agent extras, deleting unused modules and references across the codebase. Additionally, it bumps the version to 0.1.10, pins pandas as an explicit core dependency, raises the test coverage floor to 68%, and updates documentation, changelogs, and tests to reflect these changes. No review comments were provided, so there is no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
JesuFemi-O
left a comment
JesuFemi-O
left a comment
There was a problem hiding this comment.
LGTM, Thanks for working on this!
2 participants
Summary
The non-docs half of the old #150: fixes the open review comments from PR #147, and gets the branch release-ready. (The docs sweep is #151.)
Review fixes
ai_hint()and every other leftover that pointed users at the deletedtycoon askcommandstycoon ask/register llm/naoto the stale-string sentinel so this can't drift againpandas==3.0.3— it IS needed (dlt's CSV reader), just previously unexplained and unpinnedtycoon startshutdown catches specific exceptions instead ofexcept ExceptionRelease prep
docs/releases/v0.1.10.md(date stays TBD until ship)Tests
611 passed / ruff clean / mkdocs --strict clean /
tycoon --version→ 0.1.10🤖 Generated with Claude Code