fix: use vscode theme variables for error panel colors - #72
Conversation
|
Thanks for submitting a PR to fix this issue. The fix belongs in a different spot, though. In VS Code, the Could you:
--verso-cell-error-foreground: var(--vscode-inputValidation-errorForeground, var(--vscode-errorForeground, #F48771));This keeps the change scoped to VS Code, and doesn't mingle with Blazor server that's separate from the VS Code extension. |
|
Thanks for pointing me in the right direction! I updated the PR with your suggestions. |
|
Thanks for your contribution. This fix will be released in 1.0.22 or 1.1.0. We're juggling between the two because some important changes are nearly done. |
This PR fixes an issue where the error panel in notebook cells hardcoded its background and text colors, making it unreadable on custom VS Code themes like Catppuccin.
I added CSS fallback chaining to the
.verso-output--error class.It now prioritizes the native--vscode-inputValidation-errorBackgroundand--vscode-inputValidation-errorForegroundtokens, falling back to the Verso tokens and static hex colors if the VS Code variables are missing (e.g., when running in the browser).Fixes catppuccin/vscode#640