Skip to content

(#618) Automatically remove previews from gh-pages#751

Merged
dopenguin merged 1 commit into
nextfrom
fix/618-remove-previews
Jul 7, 2026
Merged

(#618) Automatically remove previews from gh-pages#751
dopenguin merged 1 commit into
nextfrom
fix/618-remove-previews

Conversation

@oeninghe-dataport

Copy link
Copy Markdown
Collaborator

Summary

Removal of previews from GH-pages fails too often.

Instructions for local reproduction and review

  • Merge PR
  • See the still existing preview

For obvious reasons, this PR is untested.

Relevant tickets, issues, et cetera

Hopefully reduces #618

@oeninghe-dataport oeninghe-dataport added this to the POLAR@3 milestone Jun 1, 2026
@oeninghe-dataport oeninghe-dataport self-assigned this Jun 1, 2026
@oeninghe-dataport oeninghe-dataport added the testing Pertaining to tests label Jun 1, 2026
@oeninghe-dataport oeninghe-dataport changed the base branch from main to next June 1, 2026 18:34

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken, the pipeline would simply stop the next step if the event is closed, right?
But how does this help with the removal of gh-pages deployments?

@oeninghe-dataport

Copy link
Copy Markdown
Collaborator Author

If I am not mistaken, the pipeline would simply stop the next step if the event is closed, right? But how does this help with the removal of gh-pages deployments?

The pipeline skips building the project when the event is a closed (i.e., merged or declined) pull request.
This is also recommended by https://github.com/rossjrw/pr-preview-action#usage
It speeds up the pipeline runtime at merging - and, even more important - it does not fail when a PR is closed that fails, for example, at npm ci.

The concurrency should prohibit conflicting jobs of the same PR that run concurrently.
This is also recommended by https://github.com/rossjrw/pr-preview-action#set-a-concurrency-group

@dopenguin dopenguin force-pushed the fix/618-remove-previews branch from 50bbb16 to 809d890 Compare July 7, 2026 16:23
@dopenguin dopenguin requested a review from a team July 7, 2026 16:23

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dopenguin dopenguin merged commit 2e1f94a into next Jul 7, 2026
6 checks passed
@dopenguin dopenguin deleted the fix/618-remove-previews branch July 7, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pertaining to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR previews are not deleted in the gh-pages branch automatically

2 participants