roll back incomplete attribution changes - #98
Merged
Conversation
dopenguin
approved these changes
Feb 2, 2024
dopenguin
left a comment
dopenguin
left a comment
Member
There was a problem hiding this comment.
I've got no knowledge how this came to be. As the prior implementation utilizing {{YEAR}} was already in place when the repository moved to GitHub, we'd have to check in the previous instance, if need be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Somehow we ended up with
{{YEAR}}instead of<YEAR>in the Attributions code. However, that is a breaking change, and to my knowledge no configurations exist where{{YEAR}}is used. Instead, the text just disappears due to our i18n package, and hence this breaking change wasn't even noticed yet.I've just rolled it back for compatibility with existing configurations. Do you know anything more about this?
Instructions for local reproduction and review
Check e.g. DISH client.