Skip to content

Fix stale commit extraction resume failures#4

Merged
apstenku123 merged 2 commits into
mainfrom
codex/commit-resume-complete-sentinel
Jul 13, 2026
Merged

Fix stale commit extraction resume failures#4
apstenku123 merged 2 commits into
mainfrom
codex/commit-resume-complete-sentinel

Conversation

@apstenku123

Copy link
Copy Markdown
Collaborator

Summary

  • ignore stale repo-level commit extraction failures once commit_plan plus exact ranges prove completion
  • persist a derived aggregate completion sentinel that clears the stale failure
  • keep failed range keys fail-closed

Verification

  • 7 focused commit completion tests passed
  • 89 conveyor and problem-repo regression tests passed
  • py_compile and git diff --check passed

Copilot AI review requested due to automatic review settings July 13, 2026 21:40
@github-actions

Copy link
Copy Markdown

🤖 Hi @apstenku123, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses resume failures caused by stale repo-level repo::commits failure records by treating exact range coverage (validated against an authoritative repo::commit_plan) as the source of truth for completion, and persisting a derived aggregate “complete” sentinel that clears the stale failure.

Changes:

  • Update manifest_complete_commit_ranges() to ignore stale repo::commits failures while still failing closed on any failed range key (repo::r*).
  • Add mark_commit_stream_complete() to persist a derived aggregate completion record (repo::commits) once exact plan+range coverage proves completion (and clear any stale aggregate failure).
  • Extend tests to cover stale aggregate failure handling and ensure failed range keys still prevent completion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/streaming_conveyor.py Adjusts commit completion proof logic to ignore stale aggregate failures, adds a derived completion sentinel, and wires it into resume/cleanup decisions.
tests/test_streaming_conveyor_progress.py Adds regression tests for stale aggregate failure ignoring, failed-range fail-closed behavior, and sentinel persistence/failed-key clearing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@apstenku123
apstenku123 merged commit 9bf8afa into main Jul 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants