Fix stale commit extraction resume failures#4
Merged
Conversation
|
🤖 Hi @apstenku123, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Pull request overview
This PR addresses resume failures caused by stale repo-level repo::commits failure records by treating exact range coverage (validated against an authoritative repo::commit_plan) as the source of truth for completion, and persisting a derived aggregate “complete” sentinel that clears the stale failure.
Changes:
- Update
manifest_complete_commit_ranges()to ignore stalerepo::commitsfailures while still failing closed on any failed range key (repo::r*). - Add
mark_commit_stream_complete()to persist a derived aggregate completion record (repo::commits) once exact plan+range coverage proves completion (and clear any stale aggregate failure). - Extend tests to cover stale aggregate failure handling and ensure failed range keys still prevent completion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/streaming_conveyor.py |
Adjusts commit completion proof logic to ignore stale aggregate failures, adds a derived completion sentinel, and wires it into resume/cleanup decisions. |
tests/test_streaming_conveyor_progress.py |
Adds regression tests for stale aggregate failure ignoring, failed-range fail-closed behavior, and sentinel persistence/failed-key clearing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification