Fix Vite alias matching for next/* imports - #29
Merged
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/david-alexandre-fernandes-projects?upgradeToPro=build-rate-limit |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nextalias captured subpath imports likenext/script, resolving to an incorrect path such assrc/shims/next/index.ts/script.next/*subpath imports resolve to their explicit shims while keeping the basenextshim available for exact matches.Description
resolve.aliaswith an ordered array of alias entries invite.config.tsso more specific aliases are matched first.{ find: /^next$/, replacement: path.resolve(__dirname, "src/shims/next/index.ts") }sonextno longer capturesnext/*imports.next/*andnext-i18next/*shims to preserve existing behavior for those subpaths.Testing
npm run build, which could not complete in this environment becauseviteis not installed locally and the command failed.npm installto restore dependencies, which failed due to403 Forbiddenfrom the npm registry, preventing a full validation of the production build.Codex Task