Fix favicon rendering in portfolio project cards - #32
Merged
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/david-alexandre-fernandes-projects?upgradeToPro=build-rate-limit |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
favicon.icodirectly fromraw.githubusercontent.com/<owner>/<repo>/..., which frequently does not exist.Description
https://www.google.com/s2/favicons?sz=256&domain_url=${encodeURIComponent(repository.homepage || repository.html_url)}insrc/components/sections/Portfolio/index.tsxso cards use the repository homepage (or repository URL) as a reliable favicon source.Testing
npm run buildwhich failed withvite: not found, rannpm ciwhich failed with403 Forbiddenwhen fetching packages, and attempted a Playwright screenshot which failed withERR_EMPTY_RESPONSE, so no successful local build/test could be completed in this environment.Codex Task