chore: rfc-compliance §6.3.3 row Supported, drop SD-NAME digression#230
Conversation
The §6.3.3 SD-PARAM value escaping row had a Partial status because the note carried a "SD-NAME syntax validation not yet enforced — E14" digression that conflated two different concerns: - The row's title is value escaping (`"`, `\`, `]`) — fully done via SolidSyslogFormatter_EscapedString. OriginSd routes software, swVersion, enterpriseId, and each ip through it; MetaSd's language callback wraps the same primitive. - SD-NAME / SD-ID syntax validation is a separate concern that only matters once callers can supply names. The three standard SDs (meta / timeQuality / origin) use compile-time-constant names, so validation protects nothing in E07's surface. Caller-supplied names arrive with E14 (Custom Structured Data) where the primitive will be adopted at SD Create time. Drop the digression, flip Partial → Supported, reword to make the E14 link a forward-looking pointer rather than a Partial-blocker. Summary table updated: RFC 5424 16/1 → 17/0 (Supported/Partial). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation update to RFC 5424 compliance matrix marks §6.3.3 SD-PARAM escaping as fully "Supported" instead of "Partial", refines escaping notes clarifying that validation applies only to custom structured-data with caller-supplied names, and increments supported compliance count from 16 to 17. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
☀️ Quality Summary 🚦 build-linux-gcc: 100% successful (✔️ 952 passed, 🙈 3 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
Summary
The §6.3.3 SD-PARAM value escaping row had a Partial status because the note carried a "SD-NAME syntax validation not yet enforced — E14" digression that conflated two different concerns:
",\,]) — fully done viaSolidSyslogFormatter_EscapedString.OriginSdroutes software, swVersion, enterpriseId, and each ip through it;MetaSd's language callback wraps the same primitive.Createtime.Drop the digression, flip Partial → Supported, reword the E14 reference as a forward-looking pointer rather than a Partial-blocker.
Summary table updated: RFC 5424 16/1 → 17/0 (Supported/Partial). With this change E07 has zero outstanding rows in the compliance matrix and the epic can close.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit