Fix Ballpit background not reacting to parameter change - #1013
Merged
Conversation
DavidHDev
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ballpit background did not react to parameter changes in Background Studio when props were updated.
Cause
The
Ballpitcomponent initialized thecreateBallpitphysics/rendering instance once inside a mountuseEffect, but had no mechanism oruseEffectto listen to subsequent prop updates and sync them to the running instance, nor anupdateConfighandler on the instance.Changes
updateConfigmethod tocreateBallpitto handle dynamic prop updates. Ifcountchanges, it re-initializes the spheres buffer; for other parameters (e.g.colors,minSize,maxSize,size0), it updates the live config, colors, and physics sizes dynamically.useEffecthook inBallpitcomponent to sync updatedpropsandfollowCursortospheresInstanceRef(skipping initial render viaisFirstRenderref).content(JS/CSS),tailwind(JS/TW),ts-default,ts-tailwind.public/r/Ballpit-{JS,TS}-{CSS,TW}.jsonregistry files.