Skip to content

fix(typings): Python 3.8 defaultdict - #117

Merged
DavidVujic merged 1 commit into
mainfrom
fix-python-3-8-typings
Oct 5, 2023
Merged

fix(typings): Python 3.8 defaultdict#117
DavidVujic merged 1 commit into
mainfrom
fix-python-3-8-typings

Conversation

@DavidVujic

@DavidVujic DavidVujic commented Oct 5, 2023

Copy link
Copy Markdown
Owner

Description

Fixes an issue with Python 3.8 and missing typings for DefaultDict.

Motivation and Context

To fix failing CI build for Python 3.8.

How Has This Been Tested?

Local test runs.
CI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
DavidVujic force-pushed the fix-python-3-8-typings branch from 8feda93 to 83b2a9f Compare October 5, 2023 19:57
@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidVujic
DavidVujic merged commit 9958499 into main Oct 5, 2023
@DavidVujic
DavidVujic deleted the fix-python-3-8-typings branch October 5, 2023 19:59
@BeRT2me

BeRT2me commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

@DavidVujic If you add this to your mypy.ini, it'll catch these :)

[mypy]
python_version = 3.8

from __future__ import annotations would be another option as well https://mypy.readthedocs.io/en/stable/runtime_troubles.html#future-annotations-import-pep-563

@DavidVujic

Copy link
Copy Markdown
Owner Author

I'll do that! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants