Skip to content

refactor(poly check, poly libs): extract poetry internals - #118

Merged
DavidVujic merged 4 commits into
mainfrom
poetry-internals
Oct 7, 2023
Merged

refactor(poly check, poly libs): extract poetry internals#118
DavidVujic merged 4 commits into
mainfrom
poetry-internals

Conversation

@DavidVujic

@DavidVujic DavidVujic commented Oct 7, 2023

Copy link
Copy Markdown
Owner

Description

Extract the poetry specific internals - the usage of EnvManager and the locker - into a separate module.

This is a continuation of #115

Motivation and Context

Refactoring and adding unit tests asserting the functionality is there also in future Poetry versions.

How Has This Been Tested?

Types of changes

  • Refactoring (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DavidVujic
DavidVujic marked this pull request as ready for review October 7, 2023 07:28
@DavidVujic
DavidVujic merged commit 5e3720b into main Oct 7, 2023
@DavidVujic
DavidVujic deleted the poetry-internals branch October 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant