Skip to content

docs: state how language negotiation and consumer overrides interact, and pin it - #9

Merged
Decipher merged 2 commits into
feature/3-changelog-drupal-10from
feature/4-language-behaviour-docs
Aug 26, 2026
Merged

docs: state how language negotiation and consumer overrides interact, and pin it#9
Decipher merged 2 commits into
feature/3-changelog-drupal-10from
feature/4-language-behaviour-docs

Conversation

@Decipher

@Decipher Decipher commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

Documents the confirmed language behaviour and pins it with a kernel test: exposed values follow interface language negotiation, per-consumer overrides apply in every language, so a key can be translated or overridden but not both at once.

Changes

  • README.md: a new FAQ entry stating the interaction plainly.
  • CHANGELOG.md: the Known limitations bullet claimed language negotiation is not handled at all, which undersells it. It now states what actually happens.
  • tests/src/Kernel/SettingsResolverLanguageTest.php: resolves under en and fr config override languages. Asserts the translated name comes back under fr with languages:language_interface in the cacheability, and that a consumer override returns the same value under both. This is the baseline per-language overrides (targeted at 1.1.0) start from.

Review notes

Stacked on the changelog branch (#8) because both edit the Known limitations block, so the diff shows its commit until #8 merges. Merge order 8 → 9 → 10 is conflict-free.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (d793dcf) to head (889b66e).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/3-changelog-drupal-10       #9   +/-   ##
==============================================================
  Coverage                          86.12%   86.12%           
==============================================================
  Files                                  9        9           
  Lines                                490      490           
==============================================================
  Hits                                 422      422           
  Misses                                68       68           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Decipher
Decipher changed the base branch from 1.0.x to feature/3-changelog-drupal-10 August 26, 2026 01:34
@Decipher
Decipher force-pushed the feature/4-language-behaviour-docs branch from 48289a8 to 5394e28 Compare August 26, 2026 01:34
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 03776280-0cfe-419e-a7ce-49f2593b7b19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Decipher
Decipher changed the base branch from feature/3-changelog-drupal-10 to 1.0.x August 26, 2026 01:49
@Decipher Decipher closed this Aug 26, 2026
@Decipher Decipher reopened this Aug 26, 2026
@Decipher Decipher changed the title docs: state how language negotiation and consumer overrides interact docs: state how language negotiation and consumer overrides interact, and pin it Aug 26, 2026
@Decipher
Decipher changed the base branch from 1.0.x to feature/3-changelog-drupal-10 August 26, 2026 05:22
@Decipher
Decipher force-pushed the feature/4-language-behaviour-docs branch from 5394e28 to 889b66e Compare August 26, 2026 05:24
@Decipher
Decipher merged commit f7bbf30 into 1.0.x Aug 26, 2026
19 checks passed
@Decipher
Decipher deleted the feature/4-language-behaviour-docs branch August 26, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant