Make page classification less expensive during crawls - #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This cleans up the NLP classifier so crawling more than one page does not retrain the model over and over. The classifier now trains lazily from the packaged CSV, stays cached for the process, and returns a confidence score for the selected category instead of the old misleading accuracy value.
I also removed the runtime
training_data/generation from classification and stopped the NLP helpers from changing the process working directory. The optional data export helper is still there for experiments, but normal crawls no longer write generated files into the package directory.Version is bumped to
4.3.0and the changelog has the release notes.Checks
.venv/bin/python -m pytest tests/test_nlp.py.venv/bin/python -m pytest.venv/bin/python -m flake8 src/torbot/modules/nlp/main.py src/torbot/modules/nlp/gather_data.py tests/test_nlp.py