Mac compatibility: Avoid PCRE grep in recon-surf, stat formatting and mapfile #672
Conversation
49dd51c to
595f3c9
Compare
|
This works on my Mac. I am getting a print out Also I wonder if we should use this PR to fix the other Mac issues:
|
Let's use this issue for that. The grep issue I was fixing here is a mac-only issue. I will fix the |
|
Still working on stat |
|
I tested mapfile changes and it works (also tested --threads 4 for parallel). One other thing, I get the run time only in full hours : Probably due to first output line: |
18a20a7 to
20b009d
Compare
20b009d to
2db6160
Compare
|
I still get |
What do you get, if you run |
|
inside the scripts it uses the system bash, which is this: in my terminal I have a newer one (5.something) via home-brew, but system bash is still old, and that is the one that gets used via the bash shebang. |
|
So the difference is that when we call |
|
it can be different depending on what other bash is installed on the system and in the path. On normal systems, it should be the same. |
e8cc761 to
b1ac4bd
Compare
|
I have changed the usage of |
Avoid using grep -P, instead use grep -E and some bash instructions.
…activate the part if it is optional.
…les) into a function in functions. This check uses `stat`, which works in different ways for macOS and linux. Make the function (stat) work for both linux (GNU coreutils) and macOS (unclear version).
use bc -l flag to use fractions as well
…he bash version number.
5f40798 to
0501882
Compare
Avoid using grep -P, instead use grep -E and some bash instructions.
This PR addresses #668 and was introduced by #652.
Needs testing to see if grep 2.6 / mac versions of grep on mac support the extended grep syntax.
This PR also addresses 2 more Mac compatibility issues:
mapfilein run_fastsurfer and brun_fastsurfer (the latter will just not be compatible for some specific flags/arguments)statwhich uses-con Linux (GNU coreutils version) and-ffor similar things on macOS (BSD version)