Bugfixes before release#700
Merged
Merged
Conversation
m-reuter
reviewed
May 28, 2025
dkuegler
force-pushed
the
fix/type-catch
branch
from
ed928d2 to
4c3c07a
Compare
m-reuter
reviewed
Aug 12, 2025
- "soft LIA" to "soft-LIA" - ArgumentTypeError to ValueError - vox_size can accept a float in addition to a str - fix image_size default value overwriting passed value - remove test from Docker - reorder vox_size and image_size check in is_conform so their order in output is swapped - set LANG to en_US in Dockerfile - fix image position when cropping with crop_transform - add inv_ornt function in conform - remove extra debug output General fixes to FastSurfer - only reset LC_NUMERIC in recon_surf/functions, if LC_NUMERIC is not en_US - set LC_NUMERIC in Dockerfile - add logfile to softlink_or_copy invocation in run_fastsurfer (was missing) - add a warning to softlink_or_copy if logfile is not set - some minor formatting fixes
dkuegler
force-pushed
the
fix/type-catch
branch
from
4c3c07a to
b0a2f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs that came up and were resolved during release testing and further review.
Fix the usage of
nibabel.orientations.ornt_transformafter clarification. nipy/nibabel#1418Fix Argument-Type related bugs.