Skip to content

Fix ruff error suppression of typing.Optional#713

Merged
dkuegler merged 2 commits into
Deep-MI:devfrom
OtabekRintaro:fix/ruff-error-suppression
Jun 23, 2025
Merged

Fix ruff error suppression of typing.Optional#713
dkuegler merged 2 commits into
Deep-MI:devfrom
OtabekRintaro:fix/ruff-error-suppression

Conversation

@OtabekRintaro
Copy link
Copy Markdown
Contributor

Problem:
Ruff rules are not suppressed. Specifically, typing.Optional, previously UP007.

Cause:
According to Ruff's latest release's notes:

non-pep604-annotation-union (UP007) has now been split into two rules.
UP007 now applies only to typing.Union, while
non-pep604-annotation-optional (UP045) checks for use of
typing.Optional. UP045 has also been stabilized in this release, but you
may need to update existing include, ignore, or noqa settings to
accommodate this change.

Issue: #712

@m-reuter
Copy link
Copy Markdown
Member

thanks, can you also fix the spell check error (just replace "softwares" by "packages")
Also instead of suppressing RUFF rules, it would be better to fix the underlying problem and use the newer convention (unless that has other consequences).

@dkuegler dkuegler merged commit 260a1e5 into Deep-MI:dev Jun 23, 2025
3 checks passed
@OtabekRintaro OtabekRintaro deleted the fix/ruff-error-suppression branch October 9, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants